update to semconv v1.26.0 and use stable attributes#55
Open
thaJeztah wants to merge 1 commit intocontainerd:mainfrom
Open
update to semconv v1.26.0 and use stable attributes#55thaJeztah wants to merge 1 commit intocontainerd:mainfrom
thaJeztah wants to merge 1 commit intocontainerd:mainfrom
Conversation
Update to the semconv version used by go.opentelemetry.io/otel v1.21.0, and update to use stable attributes; - NetSockPeerAddr (net.sock.peer.addr) -> NetworkPeerAddress (network.peer.address) - NetSockPeerPort (net.sock.peer.port) -> NetworkPeerPort (network.peer.port) Unfortunately, there's no good replacement for NetPeerName (net.peer.name) and NetPeerPort (net.peer.port). The `network.peer.address` attribute should strictly only be used for IP-addresses or socket addresses, but the description is slightly ambiguous; > network.peer.address and network.local.address should be IP addresses, Unix > domain socket names, or other addresses specific to network type. The alternatie is to use either "semconv.ClientAddress" + "semconv.ClientPort" or "semconv.ServerAddress" + "semconv.ServerPort" for hostnames. However, the code in this module is generic and doesn't distinguish between "client" and "server", and there's no equivalent for "peer address". See https://opentelemetry.io/docs/specs/semconv/general/attributes/#other-network-attributes Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Member
Author
|
@kiashok moving this one out of draft, but open to input / suggestions what the best approach would be for this; i.e., should we add the legacy ones as well (in addition to the new ones), or just switch over? |
@thaJeztah I moved to a new team and don't work on containerd now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to the semconv version used by go.opentelemetry.io/otel v1.21.0, and update to use stable attributes;
Unfortunately, there's no good replacement for NetPeerName (net.peer.name) and NetPeerPort (net.peer.port). The
network.peer.addressattribute should strictly only be used for IP-addresses or socket addresses, but the description is slightly ambiguous;The alternatie is to use either "semconv.ClientAddress" + "semconv.ClientPort" or "semconv.ServerAddress" + "semconv.ServerPort" for hostnames. However, the code in this module is generic and doesn't distinguish between "client" and "server", and there's no equivalent for "peer address".
See https://opentelemetry.io/docs/specs/semconv/general/attributes/#other-network-attributes